replacing legacy sbt-jacoco by MatloaItumeleng · Pull Request #90 · AbsaOSS/spark-data-standardization

MatloaItumeleng · 2026-03-30T10:21:31Z

Release notes:

Upgrades the legacy sbt-jacoco to the latest stable version.

closes #89

github-actions · 2026-03-30T10:23:13Z

JaCoCo code coverage report - scala 2.12.12

There is no coverage information present for the Files changed

ABLL526

LGTM, the only thing is the txt file. Can you remove the comments from it?
Other than that I will approve

MatloaItumeleng · 2026-04-01T10:34:08Z

The jmf-rules.txt file acts as a template for the project as part of Morana usage. The workflow will be updated to run coverage. For reference, see: https://github.com/MoranaApps/jacoco-method-filter/blob/master/jmf-rules.template.txt

github-actions · 2026-04-02T07:10:11Z

JaCoCo code coverage report - scala 2.12.12

Metric (instruction)	Coverage	Threshold	Status
Overall	81.57%	80.0%	✅
Changed Files	0.0%	80.0%	✅

Report	Coverage (O/Ch)	Threshold (O/Ch)	Status (O/Ch)
`spark-data-standardization Jacoco Report - scala:2.12.20`	81.57% / 0.0%	80.0% / 80.0%	✅/✅

File Path	Coverage	Threshold	Status

No changed file in reports.

TheLydonKing

Just read the code, makes sense to me.

dk1844

LGTM (read the code)

jmf-rules.txt

MatloaItumeleng · 2026-04-02T07:49:52Z

build.sbt

+jacocoReportName := s"spark-data-standardization Jacoco Report - scala:${scalaVersion.value}"
+jacocoReportFormats := Set("html", "xml")
+
+// jacocoExcludes := Seq("za/co/absa/standardization/udf/UDFBuilder*", "za/co/absa/standardization/udf/UDFNames")


Hi @miroslavpojer we also thinking about excluding some tests using the filter method please have a look for a comment

See my proposal. It filter out UDFName vals. You can place it into Project rules part of jmf-rules.txt file.

# UDFNames object — final val string constant accessors # UDFNames* matches both UDFNames$ (module) and UDFNames (static forwarders) za.co.absa.standardization.udf.UDFNames*#stdCastErr() id:udfnames-stdCastErr za.co.absa.standardization.udf.UDFNames*#stdNullErr() id:udfnames-stdNullErr za.co.absa.standardization.udf.UDFNames*#stdSchemaErr() id:udfnames-stdSchemaErr za.co.absa.standardization.udf.UDFNames*#arrayDistinctErrors() id:udfnames-arrayDistinctErrors za.co.absa.standardization.udf.UDFNames*#cleanErrCol() id:udfnames-cleanErrCol za.co.absa.standardization.udf.UDFNames*#errorColumnAppend() id:udfnames-errorColumnAppend za.co.absa.standardization.udf.UDFNames*#binaryUnbase64() id:udfnames-binaryUnbase64

miroslavpojer

pulled
ran jacoco locally

miroslavpojer · 2026-04-02T11:38:02Z

project/plugins.sbt

 lazy val ow2Version = "9.5"
-lazy val jacocoVersion = "0.8.10-absa.1"

-def jacocoUrl(artifactName: String): String = s"https://github.com/AbsaOSS/jacoco/releases/download/$jacocoVersion/org.jacoco.$artifactName-$jacocoVersion.jar"
 def ow2Url(artifactName: String): String = s"https://repo1.maven.org/maven2/org/ow2/asm/$artifactName/$ow2Version/$artifactName-$ow2Version.jar"

 addSbtPlugin("com.jsuereth" %% "scala-arm" % "2.0" from "https://repo1.maven.org/maven2/com/jsuereth/scala-arm_2.11/2.0/scala-arm_2.11-2.0.jar")
 addSbtPlugin("com.jsuereth" %% "scala-arm" % "2.0" from "https://repo1.maven.org/maven2/com/jsuereth/scala-arm_2.12/2.0/scala-arm_2.12-2.0.jar")
-
-addSbtPlugin("za.co.absa.jacoco" % "report" % jacocoVersion from jacocoUrl("report"))
-addSbtPlugin("za.co.absa.jacoco" % "core" % jacocoVersion from jacocoUrl("core"))
-addSbtPlugin("za.co.absa.jacoco" % "agent" % jacocoVersion from jacocoUrl("agent"))
 addSbtPlugin("org.ow2.asm" % "asm" % ow2Version from ow2Url("asm"))
 addSbtPlugin("org.ow2.asm" % "asm-commons" % ow2Version from ow2Url("asm-commons"))
 addSbtPlugin("org.ow2.asm" % "asm-tree" % ow2Version from ow2Url("asm-tree"))


I believe all these lines can be removed. They were part of previous jacoco sbt plugin solution.

miroslavpojer · 2026-04-02T11:40:04Z

build.sbt

+// jacocoExcludes := Seq("za/co/absa/standardization/udf/UDFBuilder*", "za/co/absa/standardization/udf/UDFNames")
+
+// Command aliases for JaCoCo coverage workflow
+addCommandAlias("jacoco", "; jacocoOn; clean; test; jacocoReportAll; jacocoOff")


These can be solved using .sbtrc file.
Just mentioning if avoided on purpose.

jmf-rules.txt

miroslavpojer · 2026-04-02T12:17:48Z

build.sbt

+jacocoReportName := s"spark-data-standardization Jacoco Report - scala:${scalaVersion.value}"
+jacocoReportFormats := Set("html", "xml")
+
+// jacocoExcludes := Seq("za/co/absa/standardization/udf/UDFBuilder*", "za/co/absa/standardization/udf/UDFNames")


See my proposal. It filter out UDFName vals. You can place it into Project rules part of jmf-rules.txt file.

# UDFNames object — final val string constant accessors # UDFNames* matches both UDFNames$ (module) and UDFNames (static forwarders) za.co.absa.standardization.udf.UDFNames*#stdCastErr() id:udfnames-stdCastErr za.co.absa.standardization.udf.UDFNames*#stdNullErr() id:udfnames-stdNullErr za.co.absa.standardization.udf.UDFNames*#stdSchemaErr() id:udfnames-stdSchemaErr za.co.absa.standardization.udf.UDFNames*#arrayDistinctErrors() id:udfnames-arrayDistinctErrors za.co.absa.standardization.udf.UDFNames*#cleanErrCol() id:udfnames-cleanErrCol za.co.absa.standardization.udf.UDFNames*#errorColumnAppend() id:udfnames-errorColumnAppend za.co.absa.standardization.udf.UDFNames*#binaryUnbase64() id:udfnames-binaryUnbase64

replacing replacing legacy sbt-jacoco

adb8ce7

MatloaItumeleng requested review from Zejnilovic, benedeki, dk1844, lsulak and yruslan as code owners March 30, 2026 10:21

MatloaItumeleng changed the title ~~replacing replacing legacy sbt-jacoco~~ replacing legacy sbt-jacoco Mar 30, 2026

reverted linting removal

4a0c9bf

ABLL526 previously approved these changes Mar 31, 2026

View reviewed changes

Jacoco workflow update

cb149e7

MatloaItumeleng dismissed ABLL526’s stale review via cb149e7 April 1, 2026 10:13

MatloaItumeleng added 3 commits April 1, 2026 18:11

testing different SHA

d36c247

Dynamic path for jacoco.xml not found

9b8cabd

jacoco workaround test

7c2bb9d

TheLydonKing approved these changes Apr 2, 2026

View reviewed changes

dk1844 approved these changes Apr 2, 2026

View reviewed changes

jmf-rules.txt Show resolved Hide resolved

MatloaItumeleng commented Apr 2, 2026

View reviewed changes

miroslavpojer reviewed Apr 2, 2026

View reviewed changes

Conversation

MatloaItumeleng commented Mar 30, 2026

Uh oh!

github-actions bot commented Mar 30, 2026

JaCoCo code coverage report - scala 2.12.12

Uh oh!

ABLL526 left a comment

Choose a reason for hiding this comment

Uh oh!

MatloaItumeleng commented Apr 1, 2026

Uh oh!

github-actions bot commented Apr 2, 2026

Uh oh!

TheLydonKing left a comment

Choose a reason for hiding this comment

Uh oh!

dk1844 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MatloaItumeleng Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

miroslavpojer Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

miroslavpojer left a comment

Choose a reason for hiding this comment

Uh oh!

miroslavpojer Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

miroslavpojer Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

miroslavpojer Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants